Remove _state directory if index has been deleted #8610
Merged
+25
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| try { | ||
| MetaDataStateFormat.deleteMetaState(nodeEnv.indexPaths(index)); | ||
| } catch (IOException ex) { | ||
| logger.warn("Failed to delete metas-tate for index {}", ex, index); |
There was a problem hiding this comment.
I also think we should re-throw the exception here and not silently fail
|
Left really minor comments but LGTM |
|
@dakrone can you take another look? |
|
LGTM, thanks for making the changes! |
Today we try to delete the index directory if all shard locks have been acquired. Yet, if this fails due to still running recoveries etc. We might re-import the index as dangeling which also can happen if the node is restarted. In contrast to the shard direcotries we can safely delete the metastate which is used to import dangling indices while leaving the shard directories untouched.
s1monw
force-pushed
the
delete_index_state
branch
from
0b01335
to
043b37d
Compare
clintongormley
added
:Core/Infra/Core
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we try to delete the index directory if all shard locks have been
acquired. Yet, if this fails due to still running recoveries etc. We might
re-import the index as dangeling which also can happen if the node is restarted.
In contrast to the shard direcotries we can safely delete the metastate which is used
to import dangling indices while leaving the shard directories untouched.