Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separately log file deletions #8662

Closed
wants to merge 3 commits into from

Conversation

mikemccand
Copy link
Contributor

Today you can turn on lucene.iw's TRACE logging, but that gives you a metric ***load of output.

This change breaks out lucene.iw.ifd separately (TRACE), and also index.store.deletes.

The logging is unfortunately redundant, meaning if Lucene deletes a file, you'll see log output from both lucene.iw.ifd and in index.store.deletes; I did this so that if something else (not Lucene) deletes a file through the Store.directory(), we'd see it logged as well.

I found only 2 places in ES that seem to be deleting files associated with a Lucene index, and I added logging there as well.

Unfortunately, these produce a lot of output ... so I did not turn them on by default.

Closes #8603

@jpountz
Copy link
Contributor

jpountz commented Nov 26, 2014

LGTM

mikemccand added a commit that referenced this pull request Nov 26, 2014
Today, you can turn on lucene.iw TRACE logging, but that produces tons
of output.  This changes breaks out separate lucene.iw.ifd and
index.store.deletes logger components (TRACE), disabled by default, to
see what part of Elasticsearch is deleting index files.

Closed #8662

Closed #8603
mikemccand added a commit that referenced this pull request Nov 26, 2014
Today, you can turn on lucene.iw TRACE logging, but that produces tons
of output.  This changes breaks out separate lucene.iw.ifd and
index.store.deletes logger components (TRACE), disabled by default, to
see what part of Elasticsearch is deleting index files.

Closed #8662

Closed #8603
@clintongormley clintongormley added :Core/Infra/Logging Log management and logging utilities and removed review labels Mar 19, 2015
@clintongormley clintongormley changed the title Core: separately log file deletions Separately log file deletions Jun 7, 2015
mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015
Today, you can turn on lucene.iw TRACE logging, but that produces tons
of output.  This changes breaks out separate lucene.iw.ifd and
index.store.deletes logger components (TRACE), disabled by default, to
see what part of Elasticsearch is deleting index files.

Closed elastic#8662

Closed elastic#8603
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement default and more granular logging on deleted files
3 participants