Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom posting formats #8746

Closed
clintongormley opened this issue Dec 2, 2014 · 7 comments · Fixed by #9741
Closed

Remove custom posting formats #8746

clintongormley opened this issue Dec 2, 2014 · 7 comments · Fixed by #9741
Assignees
Labels
>breaking :Search/Mapping Index mappings, including merging and defining field types v2.0.0-beta1

Comments

@clintongormley
Copy link

Custom posting formats (eg pulsing, direct, etc) are not supported by Lucene - they provide no bwc promise. We removed the documentation before 1.4.0.Beta1, and we should prevent users from using these codecs going forward.

At the very least, we should deprecate custom codecs and refuse to create new indices that use them. I don't know how widely used these are (I'd imagine not very widely at all), but I'd be tempted to remove them completely in 2.0.

@clintongormley clintongormley added :Analytics/Aggregations Aggregations >breaking :Search/Mapping Index mappings, including merging and defining field types v2.0.0-beta1 discuss and removed :Analytics/Aggregations Aggregations labels Dec 2, 2014
@jpountz
Copy link
Contributor

jpountz commented Jan 16, 2015

+1 to remove them completely. Given that they are not backward compatible anyway, even if we kept it there would be a high chance that loading the index would fail.

@bleskes
Copy link
Contributor

bleskes commented Jan 16, 2015

just to clarify, we do plan to keep the ability to inject custom written codes/posting formats from plugins, right?

@jpountz
Copy link
Contributor

jpountz commented Jan 16, 2015

I don't think we should. We had to work hard in order to make storage more resilient to corruptions, we should not let users add more uncertainty to the system.

@rmuir
Copy link
Contributor

rmuir commented Jan 16, 2015

+1 Adrien. I also don't think the default codec of lucene needs to support such extensibility.

@s1monw
Copy link
Contributor

s1monw commented Feb 13, 2015

+1 lets get rid of all this.

@jpountz can you take this issue?

@bleskes
Copy link
Contributor

bleskes commented Feb 13, 2015

We discussed it and it was my understanding that due to dangerous nature of replacing codecs, we are going to remove the ability to add custom one through the settings and plugins. It will still be possible to use lucene's SPI to add codecs on the lucene level, in which case one can use them via the index.code settings. I'm +1 on that.

To be clear, what I care about is removing all options to specific custom postings lists. I would be OK with not allowing to replace codecs but rather have other methods to add custom java level posting lists.

@jpountz
Copy link
Contributor

jpountz commented Feb 13, 2015

@s1monw I'll take care of it.

jpountz added a commit to jpountz/elasticsearch that referenced this issue Feb 19, 2015
…values formats.

This commit makes the `postings_format` and `doc_values_format` options of
mappings illegal on 2.0 and ignored on 1.x (meaning that the default postings
and doc values formats from the codec will be used in such a case).

This removes a fair amount of code.

Close elastic#8746 elastic#9741
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>breaking :Search/Mapping Index mappings, including merging and defining field types v2.0.0-beta1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants