Log byte and doc size for slow merges #8855
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. One readability comment would be to use |
mikemccand
added a commit
that referenced
this pull request
Dec 9, 2014
mikemccand
added a commit
that referenced
this pull request
Dec 9, 2014
| @@ -117,10 +118,17 @@ protected void doMerge(MergePolicy.OneMerge merge) throws IOException { | |||
| totalMergesNumDocs.inc(totalNumDocs); | |||
| totalMergesSizeInBytes.inc(totalSizeInBytes); | |||
| totalMerges.inc(took); | |||
| String message = String.format(Locale.ROOT, | |||
| "merge segment %s done: took %s, %.1f MB, %d docs", | |||
There was a problem hiding this comment.
can we add the [] around values? we should make this consistent with other logs merge segment [%s] done: took [%s], [%.1f MB], [%d] docs
There was a problem hiding this comment.
OK I'll add the []s
clintongormley
changed the title
clintongormley
changed the title
clintongormley
added
:Core/Infra/Logging
clintongormley
changed the title
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just added byte & doc size of the merge when we log it.
Closes #8853