Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove top level filter parameter #8862

Closed
ppf2 opened this issue Dec 10, 2014 · 7 comments
Closed

Remove top level filter parameter #8862

ppf2 opened this issue Dec 10, 2014 · 7 comments
Assignees
@javanna
Labels
>breaking good first issue low hanging fruit

Comments

@ppf2
Copy link
Member

ppf2 commented Dec 10, 2014

Let's remove top level filter (#4119) from the product. It can be confusing to end users given that we no longer document the top level filter in our guides (we only talk about post_filter now), but Marvel auto-fill still shows it as a valid clause at the top level.
@s1monw
Copy link
Contributor

s1monw commented Dec 10, 2014

+1 @clintongormley what do you think?

@dadoonet
Copy link
Member

+1 as well. Wanna me to work on a PR for this?

@clintongormley
Copy link

Definitely - it's been deprecated since 1.0.

@Mpdreamz
Copy link
Member

Should we do the same for percolator requests:

http://www.elastic.co/guide/en/elasticsearch/reference/current/search-percolate.html

and rename its filter to post_filter? or does its aggs behave slightly different from _search's aggs?

Mpdreamz added a commit to elastic/elasticsearch-net that referenced this issue Mar 11, 2015
@Mpdreamz
bit the bullet and renamed filter on _search to post_filter fix #997 …
6dfd2dd 
…in anticpation of elastic/elasticsearch#8862
@Mpdreamz Mpdreamz mentioned this issue Mar 11, 2015
Merged
@clintongormley
Copy link

@Mpdreamz the filter on percolators is different - it's essentially just like a filtered query in that case.

@clintongormley clintongormley changed the title Remove top level filter? Remove top level filter parameter Jun 6, 2015
@clintongormley clintongormley added good first issue low hanging fruit and removed :Query DSL labels Jun 6, 2015
@ycombinator ycombinator self-assigned this Jun 11, 2015
@ycombinator ycombinator mentioned this issue Jun 11, 2015
Merged
ycombinator added a commit that referenced this issue Jun 12, 2015
@ycombinator
Merge pull request #11600 from ycombinator/gh-8862
ffc4255 
Removing top-level filter parameter from search API.
ycombinator referenced this issue Jun 12, 2015
@ycombinator
Merge pull request #11640 from elastic/revert-11600-gh-8862
bb5dc60 
Revert "Removing top-level filter parameter from search API."
@ycombinator ycombinator reopened this Jun 12, 2015
@javanna
Copy link
Member

javanna commented Oct 16, 2015

Given that #11600 is in, does this need to stay open? Is there anything left to do?

@clintongormley
Copy link

@javanna that change was reverted, so yes this still needs to be done.

@javanna javanna self-assigned this Oct 27, 2015
javanna added a commit to javanna/elasticsearch that referenced this issue Oct 28, 2015
@javanna
Remove support for deprecated top level filter in search api
6616128 
Replaced by post_filter since 1.0

Closes elastic#8862
Josh-Tilles added a commit to Josh-Tilles/elastisch that referenced this issue May 18, 2016
@Josh-Tilles
tmp! Cease using deprecated top-level filter.
0ed22cd 
- <https://www.elastic.co/guide/en/elasticsearch/reference/1.7/_search_requests.html>
- <elastic/elasticsearch#9021>
- <elastic/elasticsearch#8862>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@javanna javanna

Labels
>breaking good first issue low hanging fruit
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@ycombinator @clintongormley @Mpdreamz @dadoonet @javanna @s1monw @ppf2