Tests: Make sure snapshots created with old version of elasticsearch can... #8968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imotov
added
:Distributed/Snapshot/Restore
| @@ -194,7 +210,10 @@ def parse_config(): | |||
|
|
|||
| cfg.tmp_dir = tempfile.mkdtemp() | |||
| cfg.data_dir = os.path.join(cfg.tmp_dir, 'data') | |||
| cfg.repo_dir = os.path.join(cfg.tmp_dir, 'repo-' + cfg.version) | |||
There was a problem hiding this comment.
Why is the version string needed?
There was a problem hiding this comment.
Yeah, you are right. That's overcomplicating things. I will remove it.
|
LGTM |
imotov
force-pushed
the
add-old-snapshots-test
branch
from
327211f
to
9213a61
Compare
…can be restored Closes elastic#8968
imotov
force-pushed
the
add-old-snapshots-test
branch
from
9213a61
to
fcb0186
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... be restored