Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested agg needs to reset root doc between segments. #9441

Merged
merged 1 commit into from Jan 27, 2015

Conversation

martijnvg
Copy link
Member

PR for #9437 and #9436

This bug was found by the CI which was caused by yesterday's changes to nested aggregator. This isn't a bug in a released version.

@jpountz
Copy link
Contributor

jpountz commented Jan 27, 2015

LGTM

This stuff is tricky... Thanks for adding unit tests, we definitely need more of these with aggs...

@martijnvg martijnvg merged commit d1e5368 into elastic:1.x Jan 27, 2015
@martijnvg martijnvg deleted the aggs/nested/reset_root_doc branch May 18, 2015 23:26
@clintongormley clintongormley changed the title Aggs: nested agg needs to reset root doc between segments. Nested agg needs to reset root doc between segments. Jun 7, 2015
@clintongormley clintongormley added :Search/Search Search-related issues that do not fall into other categories and removed :Nested Docs labels Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Search/Search Search-related issues that do not fall into other categories v1.4.3 v1.5.0 v2.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants