Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure jts dependency is optional for geo_point types #9462

Closed
javanna opened this issue Jan 28, 2015 · 4 comments
Closed

Make sure jts dependency is optional for geo_point types #9462

javanna opened this issue Jan 28, 2015 · 4 comments
Assignees
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >bug v1.4.5 v1.5.0 v2.0.0-beta1

Comments

@javanna
Copy link
Member

javanna commented Jan 28, 2015

jts dependency is currently optional in our maven pom, but GeoPoint depends on it at the moment (after 06667c6). We should change this and restore GeoPoint to not depend on jts, so that the dependency is effectively optional.

@javanna javanna added >bug v2.0.0-beta1 v1.5.0 :Analytics/Geo Indexing, search aggregations of geo points and shapes v1.4.3 labels Jan 28, 2015
@dadoonet
Copy link
Member

+1

@nknize nknize changed the title Make sure jts dependency is optional [GEO] Make sure jts dependency is optional for geo_point types Jan 28, 2015
@nknize
Copy link
Contributor

nknize commented Jan 28, 2015

++1

For bookkeeping I'm linking this issue with PR #9339

History: GeoPolygonFilter for geo_point types do not handle pole and dateline wrapping correctly. I corrected this issue in #8672 for geo_shape type but it relies on JTS (which is fine for geo_shape since the ShapeModule is optional). Many users rely on geo_point type's GeoPolygonFilter which suffers from the same ambiguous polygon problem. This was reported in #5968. PR #9339 corrects the issue but introduces this JTS dependency. Will submit a new PR linked to this issue that eliminates the JTS dependency.

@javanna
Copy link
Member Author

javanna commented Feb 26, 2015

@nknize I think this was solved right? Can we close or is there still work in progress to fix the issue?

@nknize
Copy link
Contributor

nknize commented Feb 26, 2015

This issue was solved. Thanks for the reminder.

@nknize nknize closed this as completed Feb 26, 2015
@clintongormley clintongormley changed the title [GEO] Make sure jts dependency is optional for geo_point types Make sure jts dependency is optional for geo_point types May 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >bug v1.4.5 v1.5.0 v2.0.0-beta1
Projects
None yet
Development

No branches or pull requests

4 participants