Remove FlushType and make resources final in InternalEngine #9565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| private final SearcherFactory searcherFactory = new SearchFactory(); | ||
| private volatile SearcherManager searcherManager; | ||
| private final SearcherManager searcherManager; |
There was a problem hiding this comment.
Wonderful these can now be final!
|
LGTM, great cleanup! |
|
Looking forward to this, this will clean up the ShadowEngine a lot also! |
|
pushed a new commit |
|
LGTM, thanks @s1monw |
This commit removes the FlushType entirely and replaces it in the most places with a simple `Engine#flush()` call. Flushing without committing the translog is now entirely private to the engine and is only called in one place.
clintongormley
changed the title
clintongormley
added
:Distributed/Distributed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the FlushType entirely and replaces it in the most places with
a simple
Engine#flush()call. Flushing without committing the translog is nowentirely private to the engine and is only called in one place.