New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting number_of_replicas on a closed index can put it in an unopenable state #9566
Comments
Hmm agreed... although I'm not sure how easy it would be to do. While the index is closed, we don't keep track of where or how many shards there are I believe. |
Yeah- I dunno. Maybe its better to just stop all replica count changes on Or more documentation but I doubt that's enough.
|
Not sure how hard it is to fix but agreed that we should document this behaviour until it's fixed. |
I tend to say that we should forbid changing these settings while the index is closed as it is not clear what the effect of it would be. I also can't think of a use case where it will be helpful. I briefly looked at the code and it looks easy to add a black list of settings for closed indices. |
…s on a closed index Issue #9566 raises the point that setting the number of shards on a closed index can lead to this index not beeing able to open again. This change in documentation is ment to warn the user about this issue.
…s on a closed index Issue #9566 raises the point that setting the number of shards on a closed index can lead to this index not beeing able to open again. This change in documentation is ment to warn the user about this issue.
…s on a closed index Issue #9566 raises the point that setting the number of shards on a closed index can lead to this index not beeing able to open again. This change in documentation is ment to warn the user about this issue.
@bleskes +1 on not allowing to change these settings! Can you open a PR for this? I think the fact that you can do this is actually a bug? |
Setting the number of replicas on a closed index can leave the index in an unopenable state since we might not be able to recover a quorum. This commit simply prevents updating this setting on a closed index. Closes elastic#9566
Setting the number of replicas on a closed index can leave the index in an unopenable state since we might not be able to recover a quorum. This commit simply prevents updating this setting on a closed index. Closes elastic#9566
Setting the number of replicas on a closed index can leave the index in an unopenable state since we might not be able to recover a quorum. This commit simply prevents updating this setting on a closed index. Closes #9566 Conflicts: src/main/java/org/elasticsearch/cluster/metadata/MetaDataUpdateSettingsService.java src/test/java/org/elasticsearch/indices/IndicesOptionsIntegrationTests.java
…s on a closed index Issue elastic#9566 raises the point that setting the number of shards on a closed index can lead to this index not beeing able to open again. This change in documentation is ment to warn the user about this issue.
From an irc conversation, someone did this:
and the index wouldn't open properly. Setting number_of_replicas back to 0 and then opening the index, and then setting number_of_replicas to 2 fixed the issue. It'd be nice if setting the number_of_replicas to something that prevents the index from opening wasn't possible.
The text was updated successfully, but these errors were encountered: