Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ability to run optimize and upgrade async #9640

Merged
merged 1 commit into from Feb 11, 2015

Conversation

rjernst
Copy link
Member

@rjernst rjernst commented Feb 10, 2015

This has been very trappy. Rather than continue to allow buggy behavior
of having upgrade/optimize requests sidestep the single shard per node
limits optimize is supposed to be subject to, this removes
the ability to run the upgrade/optimize async.

closes #9638

}
});
}
waitForMerges(flush, upgrade);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful :)

@mikemccand
Copy link
Contributor

LGTM

This has been very trappy. Rather than continue to allow buggy behavior
of having upgrade/optimize requests sidestep the single shard per node
limits optimize is supposed to be subject to, this removes
the ability to run the upgrade/optimize async.

closes elastic#9638
@rjernst
Copy link
Member Author

rjernst commented Feb 11, 2015

1.x commit is here: 21fd158

@rjernst rjernst deleted the fix/9638 branch March 24, 2015 03:02
@rjernst rjernst mentioned this pull request Apr 17, 2015
@clintongormley clintongormley changed the title Core: Remove ability to run optimize and upgrade async Remove ability to run optimize and upgrade async Jun 6, 2015
@clintongormley clintongormley added :Upgrade API and removed :Core/Infra/Core Core issues without another label labels Jun 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Core: only one optimize operation should run at once
3 participants