Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggs: Fix rounding issues when using date_histogram and time zones #9790

Closed
wants to merge 1 commit into from

Conversation

cbuescher
Copy link
Member

This fix enhances the internal time zone conversion in the
TimeZoneRounding classes that were the cause of issues with
strange date bucket keys in #9491 and #7673.

Closes #9491
Closes #7673

This fix enhances the internal time zone conversion in the
TimeZoneRounding classes that were the cause of issues with
strange date bucket keys in elastic#9491 and elastic#7673.

Closes elastic#9491
Closes elastic#7673
@jpountz
Copy link
Contributor

jpountz commented Feb 23, 2015

LGTM

@cbuescher
Copy link
Member Author

@jpountz Thanks, will merge this. Do you think this should this also go on 1.4 branch?

@jpountz
Copy link
Contributor

jpountz commented Feb 23, 2015

@cbuescher Yes, please.

@cbuescher
Copy link
Member Author

Merged with 1.4 on b7dbf1e and on 1.x with 78f0202

@javanna
Copy link
Member

javanna commented Feb 25, 2015

@cbuescher can you update labels please? Did this change in 1.x and 1.4 only, not master?

@cbuescher
Copy link
Member Author

@javanna This particular PR is just merged with 1.4 and 1.x branch since on master there was a more general refactoring of time zone roundings with #9637. Not sure if this means I should label this PR with 2.0 as well?

@javanna
Copy link
Member

javanna commented Feb 25, 2015

No I think this was just missing the 1.5.0 label. If it didn't go into master it shouldn't be marked 2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants