Improve safety when deleting files from the store #9801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1monw
force-pushed
the
get_write_lock_first
branch
from
38c0538
to
0811537
Compare
s1monw
changed the title
|
I updated this to fix other places as well where we need the write lock and added more safety. @mikemccand @rmuir can you take a look please |
|
+1 |
| } | ||
| try { | ||
| dir.deleteFile(reason, existingFile); | ||
| } catch (FileNotFoundException | NoSuchFileException ex) { |
There was a problem hiding this comment.
Hmm if we have the write lock on this dir, why would we hit FNFE/NSFE?
There was a problem hiding this comment.
good question - I will remove
|
Left a couple comments, otherwise LGTM! |
s1monw
force-pushed
the
get_write_lock_first
branch
from
0811537
to
451c9d8
Compare
Today if we delete files from the index directory we never acquire the write lock. Yet, for safety reasons we should get the write lock before we modify / delete any files. Where we can we should leave the deletion to the index writer and only delete that are necessary to delete ourself.
s1monw
force-pushed
the
get_write_lock_first
branch
from
451c9d8
to
c54bd2f
Compare
clintongormley
added
:Distributed/Store
clintongormley
changed the title
clintongormley
added
:Distributed/Engine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today if we delete files from the index directory we never acquire the
write lock. Yet, for safety reasons we should get the write lock before
we modify / delete any files. Where we can we should leave the deletion
to the index writer and only delete that are necessary to delete ourself.