wrong type for bulk updates and deletes on closed index

[robx]

$ curl -XDELETE localhost:9200/test; echo
{"error":"IndexMissingException[[test] missing]","status":404}
$ curl -XPUT localhost:9200/test/test/1 -d '{"title": "test document"}'; echo
{"_index":"test","_type":"test","_id":"1","_version":1,"created":true}
$ curl -XPOST localhost:9200/test/_close; echo
{"acknowledged":true}
$ curl -XPOST localhost:9200/_bulk -d '{"update" : {"_index": "test", "_type": "type1", "_id": "1"}}
> {"doc": {"field1": "value1"}}
> '; echo
{"took":1,"errors":true,"items":[{"index":{"_index":"test","_type":"type1","_id":"1","status":403,"error":"IndexClosedException[[test] closed]"}}]} 

The key should be update instead of index. Similar things happen for deletes. The fix against current master is trivial:

diff --git a/src/main/java/org/elasticsearch/action/bulk/TransportBulkAction.java b/src/main/java/org/elasticsearch/action/bulk/TransportBulkAction.java
index 6e48349..ffd49df 100644
--- a/src/main/java/org/elasticsearch/action/bulk/TransportBulkAction.java
+++ b/src/main/java/org/elasticsearch/action/bulk/TransportBulkAction.java
@@ -168,13 +168,13 @@ public class TransportBulkAction extends HandledTransportAction<BulkRequest, Bul
         } else if (request instanceof DeleteRequest) {
             DeleteRequest deleteRequest = (DeleteRequest) request;
             if (index.equals(deleteRequest.index())) {
-                responses.set(idx, new BulkItemResponse(idx, "index", new BulkItemResponse.Failure(deleteRequest.index(), deleteRequest.type(), deleteRequest.id(), e)));
+                responses.set(idx, new BulkItemResponse(idx, "delete", new BulkItemResponse.Failure(deleteRequest.index(), deleteRequest.type(), deleteRequest.id(), e)));
                 return true;
             }
         } else if (request instanceof UpdateRequest) {
             UpdateRequest updateRequest = (UpdateRequest) request;
             if (index.equals(updateRequest.index())) {
-                responses.set(idx, new BulkItemResponse(idx, "index", new BulkItemResponse.Failure(updateRequest.index(), updateRequest.type(), updateRequest.id(), e)));
+                responses.set(idx, new BulkItemResponse(idx, "update", new BulkItemResponse.Failure(updateRequest.index(), updateRequest.type(), updateRequest.id(), e)));
                 return true;
             }
         } else {

However, why is the type reported at all? Is it allowed to differ? Could there be multiple responses to a single action?

[clintongormley]

Hi @robx

Thanks for reporting. Would you be up for sending a PR?