Tests: Use all found index files instead of static list for static bwc tests #9854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjernst
added
>test
| DirectoryStream.Filter<Path> filter = new DirectoryStream.Filter<Path>() { | ||
| public boolean accept(Path file) throws IOException { | ||
| String filename = file.getFileName().toString(); | ||
| return filename.startsWith("index-") && filename.endsWith(".zip"); |
There was a problem hiding this comment.
Can we add a comment, somewhere, that this test looks for all indexes matching the pattern index-*.zip?
I would maybe implement it this way too as a glob, with Files.newDirectoryStream(dir, "index-*.zip")
There was a problem hiding this comment.
Nice, I didn't realize this worked. I changed it as suggested.
|
looks good, just a small suggestion |
rjernst
force-pushed
the
tests/simplify-old-index
branch
from
d734c8e
to
e8935d1
Compare
…c tests It is a pain to add a new static index, and then have to update the old index test. This removes the need for the latter step. closes elastic#9854
rjernst
force-pushed
the
tests/simplify-old-index
branch
from
e8935d1
to
d479611
Compare
rjernst
added a commit
that referenced
this pull request
Feb 24, 2015
…c tests It is a pain to add a new static index, and then have to update the old index test. This removes the need for the latter step. closes #9854
rjernst
added a commit
that referenced
this pull request
Feb 24, 2015
…c tests It is a pain to add a new static index, and then have to update the old index test. This removes the need for the latter step. closes #9854
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
…c tests It is a pain to add a new static index, and then have to update the old index test. This removes the need for the latter step. closes elastic#9854
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a pain to add a new static index, and then have to update the old
index test. This removes the need for the latter step.