Lock down _ttl field
#9914
Merged
Lock down _ttl field
#9914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, this kind of problems is a source of terrible bugs since things would work fine on a single node but fail badly as soon as you have several of them since serialization looses information... Thanks for fixing! LGTM |
|
+1 |
While the parser allowed changing field type settings, these would never have been serialized. So this change simply removes parsing using parseField. Backcompat will still work if a user uploads old settings (they just would never have worked anyways, so we continue ignoring them with 1.x, and 2.x will now error). see elastic#8143 closes elastic#9914
rjernst
force-pushed
the
fix/8143-ttl
branch
from
7668ca7
to
dd0084d
Compare
rjernst
added a commit
that referenced
this pull request
Feb 27, 2015
rjernst
added
>breaking
v2.0.0-beta1
:Search/Mapping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the parser allowed changing field type settings, these would never
have been serialized. So this change simply removes parsing using
parseField. Backcompat will still work if a user uploads old settings
(they just would never have worked anyways, so we continue ignoring
them with 1.x, and 2.x will now error).
see #8143