Remote reindex failure parse fix #42928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A search request that partially fails with failures without an index (index: null) in the failure would cause a parse error in reindex from remote. This would hide the original exception, making it hard to debug the root cause. This commit fixes this so that we can tolerate null index entries in a search failure.
henningandersen
added
>bug
v8.0.0
v7.2.0
:Distributed/Reindex
|
Pinging @elastic/es-distributed |
henningandersen
added a commit
that referenced
this pull request
Jun 13, 2019
A search request that partially fails with failures without an index (index: null) in the failure would cause a parse error in reindex from remote. This would hide the original exception, making it hard to debug the root cause. This commit fixes this so that we can tolerate null index entries in a search failure.
henningandersen
added a commit
that referenced
this pull request
Jun 13, 2019
A search request that partially fails with failures without an index (index: null) in the failure would cause a parse error in reindex from remote. This would hide the original exception, making it hard to debug the root cause. This commit fixes this so that we can tolerate null index entries in a search failure.
henningandersen
added a commit
that referenced
this pull request
Jun 13, 2019
A search request that partially fails with failures without an index (index: null) in the failure would cause a parse error in reindex from remote. This would hide the original exception, making it hard to debug the root cause. This commit fixes this so that we can tolerate null index entries in a search failure.
henningandersen
added a commit
that referenced
this pull request
Jun 13, 2019
ShardSearchFailure.toXContent did not generate the outer level object, fixed test to add this. Related to backport of #42928
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A search request that partially fails with failures without an index
(index: null) in the failure would cause a parse error in reindex from
remote. This would hide the original exception, making it hard to debug
the root cause. This commit fixes this so that we can tolerate null
index entries in a search failure.