Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skip_major option to docker/diskio #3254

Merged

Conversation

fearful-symmetry
Copy link
Contributor

What does this PR do?

This adds A skip_major option, in line with what's now supported in metricbeat itself.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@fearful-symmetry fearful-symmetry added enhancement New feature or request Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels May 2, 2022
@fearful-symmetry fearful-symmetry requested a review from a team as a code owner May 2, 2022 19:18
@fearful-symmetry fearful-symmetry self-assigned this May 2, 2022
@elasticmachine
Copy link

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@elasticmachine
Copy link

elasticmachine commented May 2, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-03T15:51:41.189+0000

  • Duration: 21 min 57 sec

Test stats 🧪

Test Results
Failed 0
Passed 36
Skipped 0
Total 36

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented May 2, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 3.218
Classes 100.0% (0/0) 💚 3.218
Methods 100.0% (27/27) 💚 11.77
Lines 100.0% (0/0) 💚 10.001
Conditionals 100.0% (0/0) 💚

@jlind23 jlind23 requested review from a team, rdner and kvch and removed request for a team May 3, 2022 06:33
@fearful-symmetry fearful-symmetry merged commit bfbe34a into elastic:main May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants