New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Facets incorrect when scrolling #1642
Comments
Mmm, interesting.... I did not cover the case of using faceting with scrolling since I did not think it makes sense, but, it should at least be consistent... . |
We should probably only return facets on the first request, and not on scrolls |
+1 to only return facets on the first request |
I'm wondering if it's a common use case to ask for facets when doing scrolling... I would vote to not compute facets at all when doing scroll or to reject the query with a clear error message. |
@dadoonet i've just had pecke01 in IRC saying that he has customers who are using facets with scrolling, and I don't see any reason to remove them on the first request. but it is meaningless to calculate them on subsequent requests |
well even if it's not a common usecase it seems pretty straight forward form an API perspective to just return the facets on the first response no? |
What is the status of this issue? |
I don't think anything further has happened, but I think a reasonable resolution would be to disable facets/aggs on subsequent scroll requests. /cc @uboness |
In fact, in master, the call to _scroll with facets now throws an NPE:
Aggregations return the correct counts on each call to scroll, but it still makes more sense to me to only return them on the first request. |
Aggregations are collection-wide statistics so they would always be the same. In order to save CPU/bandwidth, we can just return them on the first page. Same as elastic#1642 but for aggregations.
Aggregations are collection-wide statistics so they would always be the same. In order to save CPU/bandwidth, we can just return them on the first page. Same as #1642 but for aggregations.
Aggregations are collection-wide statistics so they would always be the same. In order to save CPU/bandwidth, we can just return them on the first page. Same as #1642 but for aggregations.
Closing this issue as facets are deprecated and the issue has been fixed for aggregations via #7497. |
Aggregations are collection-wide statistics so they would always be the same. In order to save CPU/bandwidth, we can just return them on the first page. Same as #1642 but for aggregations.
When requesting facets on a scrolled search, the counts just keep rising, incorrectly.
I'd say it makes more sense to only return the facets on the first request, not on subsequent scroll requests
Then run facets:
The text was updated successfully, but these errors were encountered: