GeoJSONShapParser can parse MultiLineString and GeometryCollection #2796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
just fyi: multilinestring is supported in the meantime. Need to investigate why GeometryCollection isnt. Out of curiousity: Do you have a particular use-case for that one? |
|
The geo_shape parsing code has changed quite a bit since this PR was created. I have re-implemented the functionality on the up to date codebase in #7123. Closing this PR in favour of the new version |
colings86
added a commit
that referenced
this pull request
Aug 18, 2014
colings86
added a commit
that referenced
this pull request
Sep 8, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is an update of the GeoJSON Shape Parser so it can parse MultiLineString and GeometryCollection.
As far as I know, this was the only reason why elasticsearch geo_shape type was not supporting MultiLineString and GeometryCollection.