(Java) Using primitive arrays instead of Object with map/builder

[amir20]

One might argue that not being able to handle primitive arrays is not a bug. I wanted to report this anyway because it took me a very long time to debug. When doing something like this

Map<String, Object> map = ...;
map.put(LON_LAT, new double[]{123, 321});

client.index(new IndexRequestBuilder(client, indexName())
                        .setId(...)
                        .setType(...)
                        .setSource(map)
                        .request());

I received

Caused by: org.elasticsearch.ElasticSearchIllegalArgumentException: the character '[' is not a valid geohash character
    at org.elasticsearch.common.geo.GeoHashUtils.decode(GeoHashUtils.java:280)
    at org.elasticsearch.common.geo.GeoHashUtils.decodeCell(GeoHashUtils.java:320)
    at org.elasticsearch.common.geo.GeoHashUtils.decode(GeoHashUtils.java:297)
    at org.elasticsearch.common.geo.GeoHashUtils.decode(GeoHashUtils.java:286)
    at org.elasticsearch.index.mapper.geo.GeoPointFieldMapper.parseGeohash(GeoPointFieldMapper.java:456)
    at org.elasticsearch.index.mapper.geo.GeoPointFieldMapper.parseStringLatLon(GeoPointFieldMapper.java:382)
    at org.elasticsearch.index.mapper.geo.GeoPointFieldMapper.parse(GeoPointFieldMapper.java:367)
    at org.elasticsearch.index.mapper.object.ObjectMapper.serializeValue(ObjectMapper.java:599)
    at org.elasticsearch.index.mapper.object.ObjectMapper.parse(ObjectMapper.java:467)
    at org.elasticsearch.index.mapper.object.ObjectMapper.serializeObject(ObjectMapper.java:515)
    at org.elasticsearch.index.mapper.object.ObjectMapper.parse(ObjectMapper.java:457)
    at org.elasticsearch.index.mapper.DocumentMapper.parse(DocumentMapper.java:507)
    ...

Changing new double[]{} to new Double[]{} fixes the problem. Looking at XContentMapConverter.java, I have found that writeValue(...) does not handle primitive arrays.

Depending how you look at it, this can be a bug. :)

[kimchy]

a bug or not, we can fix it.

[amir20]

Fix looks good. Thanks for the immediate follow up. Cheers!