dynamically updating index.gc_deletes not working

[sfussenegger]

It seems that dynamically changing index.gc_deletes is broken. The corresponding field in code is RobinEngine.gcDeletesInMillis

this.gcDeletesInMillis = indexSettings.getAsTime(INDEX_GC_DELETES, TimeValue.timeValueSeconds(60)).millis();

It is only ever modified after a previous info log:

if (gcDeletesInMillis != RobinEngine.this.gcDeletesInMillis) {
     logger.info("updating index.gc_deletes from [{}] to [{}]", TimeValue.timeValueMillis(RobinEngine.this.gcDeletesInMillis), TimeValue.timeValueMillis(gcDeletesInMillis));
     RobinEngine.this.gcDeletesInMillis = gcDeletesInMillis;
}

This line never gets logged though.

Reopening the index works as expected.

[bleskes]

@sfussenegger I fixed this recently in master as part of a bigger change. I will port that little fix to the 0.90 branch and it will be available in the next release.