Disabled parent/child queries in the delete by query api. #5916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -54,6 +54,9 @@ public TopChildrenQueryParser() { | |||
|
|
|||
| @Override | |||
| public Query parse(QueryParseContext parseContext) throws IOException, QueryParsingException { | |||
There was a problem hiding this comment.
I think you should generalize this in a utils methods like
public void ensureNotDeleteByQuery(QueryParser parser, QueryParseContext parseContext) {
if ("delete_by_query".equals(SearchContext.current().source())) {
throw new QueryParsingException(parseContext.index(), "[" + parser.names()[0] + "] unsupported in delete_by_query api");
}
}that way you only need to have that logic in one place....
There was a problem hiding this comment.
Agreed! I'll change that.
|
left one comment - look close :) thanks! |
|
Updated the PR to move the delete by query api usage checking into one place. |
|
It's not super urgent but maybe we should move this method into a |
|
Updated the PR and moved the method to |
…roperly implemented and could lead to a shard being failed and not able to recover. Closes elastic#5828
| * Ensures that the query parsing wasn't invoked via the delete by query api. | ||
| */ | ||
| public static void ensureNotDeleteByQuery(String name, QueryParseContext parseContext) { | ||
| if ("delete_by_query".equals(SearchContext.current().source())) { |
There was a problem hiding this comment.
can we use a constant here? and use it both here and in the delete by query action?
|
lets a small comment, LGTM otherwise. |
|
Pushed via: 17a5575 |
This was referenced Nov 25, 2014
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
It wasn't properly implemented and could lead to a shard being failed and not able to recover. Closes elastic#5828 elastic#5916
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
It wasn't properly implemented and could lead to a shard being failed and not able to recover. Closes elastic#5828 elastic#5916
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #5828