Snapshot/Restore: Add ability to restore partial snapshots #6368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -82,6 +82,7 @@ protected void masterOperation(final RestoreSnapshotRequest request, ClusterStat | |||
| .renamePattern(request.renamePattern()) | |||
| .renameReplacement(request.renameReplacement()) | |||
| .includeGlobalState(request.includeGlobalState()) | |||
There was a problem hiding this comment.
this one becomes too dangerous IMO. It's the only place we use this class and we risk to miss passing on a parameter. IMO we should remove all the setters and make this a struct like immutalbe class taking all the values here as ctor args. The information what they are is already there via the getter and the compiler should tell us if we have to pass on any further information!
|
added some comments... seems close |
|
@s1monw - makes sense. Thanks! Fixed. |
|
LGTM |
clintongormley
changed the title
clintongormley
added
v2.0.0-beta1
:Distributed/Snapshot/Restore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5742