Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aggregations: Return an upper bound of the maximum error for terms #6696

Closed
jpountz opened this issue Jul 2, 2014 · 0 comments
Closed

Aggregations: Return an upper bound of the maximum error for terms #6696

jpountz opened this issue Jul 2, 2014 · 0 comments
Assignees
@colings86
Labels
>enhancement good first issue low hanging fruit v1.4.0.Beta1 v2.0.0-beta1

Comments

@jpountz
Copy link
Contributor

jpountz commented Jul 2, 2014

The fact that terms aggregations don't give accurate counts is a bit deceptive. Without changing the way they are implemented, maybe we should make terms aggregations return an upper bound of the maximum error on the document count as part of the response? I think this would help make clear that there are potential accuracy issues, as well as make this inaccuracy easier to manage since there is a known upper bound on the error?
@jpountz jpountz self-assigned this Jul 2, 2014
@jpountz jpountz mentioned this issue Jul 2, 2014
Closed
@martijnvg martijnvg assigned colings86 and unassigned jpountz Jul 4, 2014
@colings86 colings86 mentioned this issue Jul 8, 2014
Closed
colings86 added a commit that referenced this issue Jul 25, 2014
@colings86
Aggregations: Added an option to show the upper bound of the error fo…
f516b45 
…r the terms aggregation.

This is only applicable when the order is set to _count.  The upper bound of the error in the doc count is calculated by summing the doc count of the last term on each shard which did not return the term.  The implementation calculates the error by summing the doc count for the last term on each shard for which the term IS returned and then subtracts this value from the sum of the doc counts for the last term from ALL shards.

Closes #6696
@jasontedor jasontedor mentioned this issue May 12, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colings86 colings86

Labels
>enhancement good first issue low hanging fruit v1.4.0.Beta1 v2.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added an option to show the upper bound of the error for the terms aggregation
4 participants
@clintongormley @colings86 @jpountz @martijnvg