Do not fail whole request on closed index #6790
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@spinscale would this fix also handle the case mentioned in #6410 (comment) when indexing into a non-existent index with |
| String type = null; | ||
| String id = null; | ||
| boolean isClosed = false; | ||
| if (request instanceof IndexRequest) { |
There was a problem hiding this comment.
dude can we extract and interface that we can implement on all of them that allows use to return index, type, id?
|
added some comments |
The bulk API request was marked as completely failed, in case a request with a closed index was referred in any of the requests inside of a bulk one. Closes elastic#6410
|
@clintongormley added another test when |
| * | ||
| * Forces this class return index/type/id getters | ||
| */ | ||
| public interface SingleDocumentWriteRequest { |
There was a problem hiding this comment.
maybe we should call it Indexable or DocumentRequest something like this and it should also have a routing or even better the common denominator of update / delete / index ie all the methods they share?
|
I added some comments |
clintongormley
changed the title
lcawl
added
:Distributed/CRUD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bulk API request was marked as completely failed,
in case a request with a closed index was referred in
any of the requests inside of a bulk one.
Implementation Note: Currently the implementation is a bit more verbose in order to prevent an
instanceofcheck and another cast - if that is fast enough, we could execute that logic only once at the beginning of the loop (thinking this might be a bit overoptimization here).Closes #6410