Security: Support regular expressions for CORS allow-origin to match against #6923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| String originHeader = request.header("Origin"); | ||
| if (Strings.isNullOrEmpty(originHeader) || corsPattern == null) { | ||
| if (corsPattern != null) { | ||
| resp.headers().add("Access-Control-Allow-Origin", "*"); |
There was a problem hiding this comment.
can we make the "Access-Control-Allow-Origin" a constant?
|
@spinscale I reviewed it and left some comments. Overall I think it looks good |
|
@s1monw added tests, incorporated your comments |
|
LGTM |
This commit adds regular expression support for the allow-origin header depending on the value of the request `Origin` header. The existing HttpRequestBuilder is also extended to support the OPTIONS HTTP method. Relates elastic#5601 Closes elastic#6891
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds regular expression support for the allow-origin
header depending on the value of the request
Originheader.Relates #5601
Closes #6891