Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to register custom rivers under a custom type name (And not full class names) #712

Closed
kimchy opened this issue Feb 22, 2011 · 1 comment

Comments

@kimchy
Copy link
Member

kimchy commented Feb 22, 2011

Allow to register custom rivers under a custom type name (And not full class names) easily. For example:

public class TwitterRiverPlugin extends AbstractPlugin {

    @Inject public TwitterRiverPlugin() {
    }

    @Override public String name() {
        return "river-twitter";
    }

    @Override public String description() {
        return "River Twitter Plugin";
    }


    @Override public void processModule(Module module) {
        if (module instanceof RiversModule) {
            ((RiversModule) module).registerRiver("twitter", TwitterRiverModule.class);
        }
    }
}

The processModule can register the twitter type for the twitter river module that handles it.

@kimchy
Copy link
Member Author

kimchy commented Feb 22, 2011

Allow to register custom rivers under a custom type name (And not full class names), closed by 45ec2c6.

mindw pushed a commit to mindw/elasticsearch that referenced this issue Sep 5, 2022
Fix coventry account number

Approved-by: fabien
cbuescher pushed a commit to cbuescher/elasticsearch that referenced this issue Oct 2, 2023
We are using a rather old version of Ansible which has issues with more
recent Python versions that we use, resulting in the error:

```
PLAY [Configures Rally locally] ************************************************************************************
[WARNING]: Skipping plugin (/home/dl/source/elastic/night-rally/.venv/lib/python3.8/site-
packages/ansible/plugins/filter/core.py) as it seems to be invalid: cannot import name 'environmentfilter' from
'jinja2.filters' (/home/dl/source/elastic/night-rally/.venv/lib/python3.8/site-packages/jinja2/filters.py)
[WARNING]: Skipping plugin (/home/dl/source/elastic/night-rally/.venv/lib/python3.8/site-
packages/ansible/plugins/filter/mathstuff.py) as it seems to be invalid: cannot import name 'environmentfilter'
from 'jinja2.filters' (/home/dl/source/elastic/night-rally/.venv/lib/python3.8/site-packages/jinja2/filters.py)

TASK [rally-configure : install Rally config file] *****************************************************************
fatal: [localhost]: FAILED! => {"msg": "template error while templating string: No filter named 'bool'.. String: {{ not local_setup | default() | bool }}"}
```

Fix the issue by bumping Ansible to match the version used by esbench.
emilykmarx pushed a commit to emilykmarx/elasticsearch that referenced this issue Dec 26, 2023
)

Only use the type field for the event for ES versions < 6.0.

Since 6.0 only supports a single type this behavior can be problematic as
multiple types will break ES.

Fixes logstash-plugins/logstash-output-elasticsearch#708

* fix tests to support new maximum_node_version feature and type computation
* fix integration tests for new type decider
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant