Add executable flag to every file in bin/ after install #7177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess this should work on windows as well, right? |
|
@dadoonet can you run the branch and its tests on windows? |
|
@spinscale Will try tonight probably. |
|
tested on one windows system, where the |
|
LGTM |
The PluginManager does not preserve permissions on install. This patch sets the executable flag on every file in bin/ on plugin install. Closes elastic#7177
spinscale
added a commit
that referenced
this pull request
Aug 14, 2014
The PluginManager does not preserve permissions on install. This patch sets the executable flag on every file in bin/ on plugin install. Closes #7177
spinscale
added a commit
that referenced
this pull request
Sep 8, 2014
The PluginManager does not preserve permissions on install. This patch sets the executable flag on every file in bin/ on plugin install. Closes #7177
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PluginManager does not preserve permissions on install due to using platform independent
ZipEntryclass. This patch sets the executable flag on every file in bin/ on plugin install as one is supposed to install executables in there.