Remove operationThreaded setter from ExplainRequestBuilder #7186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… already available in base class SingleShardOperationRequestBuilder It also didn't follow the setter convention that we adopted for request builders. Fixed also javadocs warning caused byt missing descriptions for tag.
|
LGTM |
javanna
added a commit
that referenced
this pull request
Aug 7, 2014
… already available in base class SingleShardOperationRequestBuilder It also didn't follow the setter convention that we adopted for request builders. Fixed also javadocs warning caused byt missing descriptions for tag. Closes #7186
|
Side note: this change is marked as breaking as it removes a method from the Java API. Fixing compilation errors caused by this is very easy though, just replace |
javanna
added a commit
that referenced
this pull request
Sep 8, 2014
… already available in base class SingleShardOperationRequestBuilder It also didn't follow the setter convention that we adopted for request builders. Fixed also javadocs warning caused byt missing descriptions for tag. Closes #7186
clintongormley
changed the title
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's already available in base class
SingleShardOperationRequestBuilderand it doesn't follow the setter convention that we adopted for request builders.Fixed also javadocs warning caused byt missing descriptions for tag.