Function Score: Remove explanation of query score from functions #7245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The change looks good, maybe we should remove the query explanation from the parameters of |
…) and leave only the score This also removes ExplainableSearchScript which is not used anywhere and was the only reason to have the Explanation in the parameter anyway.
|
Ok, I removed the query explanation from the parameters of explainScore. However, it was used by ExplainableSearchScript. But this class seems to be used nowhere, so I removed it. |
|
LGTM |
brwe
added a commit
that referenced
this pull request
Aug 18, 2014
The score is explained already, it should not be again explained per function. Also, remove explanation from parameter list of ScoreFunction#explainScore() and leave only the score. This also removes ExplainableSearchScript which is not used anywhere and was the only reason to have the Explanation in the parameter anyway. closes #7245
brwe
added a commit
that referenced
this pull request
Sep 8, 2014
The score is explained already, it should not be again explained per function. Also, remove explanation from parameter list of ScoreFunction#explainScore() and leave only the score. This also removes ExplainableSearchScript which is not used anywhere and was the only reason to have the Explanation in the parameter anyway. closes #7245
clintongormley
changed the title
brwe
added a commit
to brwe/elasticsearch
that referenced
this pull request
Nov 26, 2014
explainable scripts were removed in elastic#7245 but they were used. This commit adds them again. closes elastic#8561
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
explainable scripts were removed in elastic#7245 but they were used. This commit adds them again. closes elastic#8561
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.