Remove the logic to optionally sort/dedup values on the fly. #7276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
… fly. These options are not used anymore. Instead numeric values can now contain dups and it is the responsibility of the aggregation to deal with it (eg. terms). And otherwise all values sources are now sorted, which is the contract of the interfaces that they implement.
jpountz
force-pushed
the
fix/aggs_required_sorted_unique
branch
from
193c1bd
to
12bcd8f
Compare
jpountz
added a commit
that referenced
this pull request
Aug 21, 2014
… fly. These options are not used anymore. Instead numeric values can now contain dups and it is the responsibility of the aggregation to deal with it (eg. terms). And otherwise all values sources are now sorted, which is the contract of the interfaces that they implement. Close #7276
jpountz
added a commit
that referenced
this pull request
Sep 8, 2014
… fly. These options are not used anymore. Instead numeric values can now contain dups and it is the responsibility of the aggregation to deal with it (eg. terms). And otherwise all values sources are now sorted, which is the contract of the interfaces that they implement. Close #7276
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These options are not used anymore. Instead numeric values can now contain dups
and it is the responsibility of the aggregation to deal with it (eg. terms).
And otherwise all values sources are now sorted, which is the contract of the
interfaces that they implement.