Report conflict when trying to disable _ttl
#7316
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, add a line about that it can never be disabled after it was enabled.
_ttl could never be disabled once it was enabled. But when trying to, no conflict was reported. relates to elastic#777 and elastic#7293
| @@ -238,12 +239,14 @@ public XContentBuilder toXContent(XContentBuilder builder, Params params) throws | |||
| @Override | |||
| public void merge(Mapper mergeWith, MergeContext mergeContext) throws MergeMappingException { | |||
| TTLFieldMapper ttlMergeWith = (TTLFieldMapper) mergeWith; | |||
| if (!mergeContext.mergeFlags().simulate()) { | |||
There was a problem hiding this comment.
I think you should not ignore it completely? The contract is that is simulate is true then conflicts are reported but changes are not performed.
There was a problem hiding this comment.
Yes! Thank god for code reviews...
There was a problem hiding this comment.
I added a commit and tests for this that were missing before
|
Adressed all comments. |
|
LGTM |
clintongormley
changed the title
_ttl
clintongormley
added
the
:Search/Mapping
clintongormley
changed the title
_ttl_ttl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_ttl could never be disabled once it was enabled.
But when trying to, no conflict was reported.
relates to #777 and #7293