Warmer (search) to support query cache #7326
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allow for search based warmer to support query cache flag on the search request, and use the index level query caching flag if set. Note, this change required changing the logic in warmer, to pass the actual searcher that will be used on for the actual search requests to the warmers. This changes the previous behavior of only using readers that were not warmed during merges, or already around. This change simplifies the warmer code significantly, and the overhead will be very small for existing warmed readers (like after a merge), yet allow us to implement warmers like the query cache (and actually have a cleaner contract, "same as search"). closes elastic#7326
|
@jpountz hey, would for you to look at this, since in order to change that, I ended up changing the warmer logic in which searcher to provide. |
| indicesQueryCache.load(request, context, queryPhase); | ||
| } else { | ||
| queryPhase.execute(context); | ||
| } |
There was a problem hiding this comment.
These 5 lines are exactly the same as in executeQueryPhase, maybe this should be extracted to a utility method?
|
I am worried that this might have significant impact on users who have large shards/lots of warmer queries/complex warmer queries? I wouldn't be surprised that warmer queries often use a |
try and keep the existing only warm new segments, but extend the top warming to also execute in search, also, make methods names a bit more readable
| boolean canCache = indicesQueryCache.canCache(request, context); | ||
| // early terminate when we can cache, since we can only do proper caching on top level searcher | ||
| // also, if we can't cache, and its top, we don't need to execute it, since we already did when its not top | ||
| if ((canCache && !top) || (!canCache && top)) { |
There was a problem hiding this comment.
This looks like a complicated way to say if (canCache != top)?
|
LGTM, I just left minor (costmetics) comments |
kimchy
added a commit
that referenced
this pull request
Aug 20, 2014
allow for search based warmer to support query cache flag on the search request, and use the index level query caching flag if set. closes #7326
kimchy
added a commit
that referenced
this pull request
Sep 8, 2014
allow for search based warmer to support query cache flag on the search request, and use the index level query caching flag if set. closes #7326
clintongormley
changed the title
clintongormley
changed the title
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow for search based warmer to support query cache flag on the search request, and use the index level query caching flag if set.
Note, this change required changing the logic in warmer, to pass the actual searcher that will be used on for the actual search requests to the warmers. This changes the previous behavior of only using readers that were not warmed during merges, or already around. This change simplifies the warmer code significantly, and the overhead will be very small for existing warmed readers (like after a merge), yet allow us to implement warmers like the query cache (and actually have a cleaner contract, "same as search").