Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If _parent field points to a non existing parent type, then skip the has_parent query/filter #7362

Merged
merged 1 commit into from Aug 27, 2014

Conversation

martijnvg
Copy link
Member

PR for #7349

@jpountz
Copy link
Contributor

jpountz commented Aug 26, 2014

Given that the extraction of the parent filter gets a bit more complicated, maybe this should be extracted to a utility method to make sure it doesn't get out-of-sync between the query and the filter?

@jpountz jpountz removed the review label Aug 26, 2014
@martijnvg
Copy link
Member Author

@jpountz good point, I'll change that.

@martijnvg
Copy link
Member Author

@jpountz Updated the pr, and common parsing logic has been moved to a static helper method.

@jpountz
Copy link
Contributor

jpountz commented Aug 26, 2014

LGTM

@martijnvg martijnvg changed the title If _parent field points to a non existing parent type, then skip the has_child query/filter If _parent field points to a non existing parent type, then skip the has_parent query/filter Aug 27, 2014
@martijnvg martijnvg merged commit d414d89 into elastic:master Aug 27, 2014
martijnvg added a commit that referenced this pull request Aug 27, 2014
…then skip the has_parent query/filter

Closes #7362
Closes #7349
martijnvg added a commit that referenced this pull request Aug 27, 2014
…then skip the has_parent query/filter

Closes #7362
Closes #7349
@spinscale spinscale changed the title If _parent field points to a non existing parent type, then skip the has_parent query/filter Parent/Child: If _parent field points to a non existing parent type, then skip the has_parent query/filter Aug 27, 2014
martijnvg added a commit that referenced this pull request Sep 8, 2014
…then skip the has_parent query/filter

Closes #7362
Closes #7349
@martijnvg martijnvg deleted the bugs/has_child_parser_npe branch May 18, 2015 23:30
@clintongormley clintongormley changed the title Parent/Child: If _parent field points to a non existing parent type, then skip the has_parent query/filter If _parent field points to a non existing parent type, then skip the has_parent query/filter Jun 7, 2015
mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015
@clintongormley clintongormley added :Search/Search Search-related issues that do not fall into other categories and removed :Parent/Child labels Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Search/Search Search-related issues that do not fall into other categories v1.3.3 v1.4.0.Beta1 v2.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants