Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed ConcurrentHashMapV8 #7392

Closed
wants to merge 1 commit into from
Closed

Removed ConcurrentHashMapV8 #7392

wants to merge 1 commit into from

Conversation

cfontes
Copy link
Contributor

@cfontes cfontes commented Aug 22, 2014

Basically reverting #6400 as requested by @mikemccand

Closes #7296

@cfontes cfontes mentioned this pull request Aug 22, 2014
Closed
@mikemccand
Copy link
Contributor

Thank you @cfontes I see your CLA on file ... I'll have a look here.

@mikemccand
Copy link
Contributor

OK this LGTM, I'll push shortly. Thank you @cfontes!

mikemccand added a commit that referenced this pull request Aug 26, 2014
@mikemccand
Core: use Java's built-in ConcurrentHashMap
3f44319 
It's risky to have our own snapshot of Java 8's ConcurrentHashMap:
unless we keep the sources in sync over time (and OpenJDK's version
had already diverged), then we won't get bug/performance fixes.  Users
can choose to upgrade to Java 8 to see the improvements of CHM.

Closes #7392

Closes #7296
@cfontes
Copy link
Contributor Author

cfontes commented Aug 27, 2014

Thank you! ES is awesome, feels great to help.

mikemccand added a commit that referenced this pull request Sep 8, 2014
@mikemccand @areek
Core: use Java's built-in ConcurrentHashMap
0fd6c46 
It's risky to have our own snapshot of Java 8's ConcurrentHashMap:
unless we keep the sources in sync over time (and OpenJDK's version
had already diverged), then we won't get bug/performance fixes.  Users
can choose to upgrade to Java 8 to see the improvements of CHM.

Closes #7392

Closes #7296
@clintongormley clintongormley changed the title removing JSR-166e ConcurrentHashMap Internal: Removed ConcurrentHashMapV8 Sep 11, 2014
@clintongormley clintongormley changed the title Internal: Removed ConcurrentHashMapV8 Removed ConcurrentHashMapV8 Jun 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mikemccand mikemccand

Labels
>enhancement v1.4.0.Beta1 v2.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Core: remove ConcurrentHashMapV8
4 participants
@cfontes @mikemccand @dakrone @clintongormley