New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the field data loading option to the _parent
field.
#7402
Add support for the field data loading option to the _parent
field.
#7402
Conversation
@martijnvg I think there is an issue with the serialization of the mapper that always serializes the fielddata settings. If I do this:
Then I get
Although I should not get fielddata settings since those are the defaults? |
(I think the issue comes from the fact that you initialize fielddataSettings to the defaults instead of |
@jpountz I see, I'll address that and make sure it only gets serialized when the loading is not equal to "eager". |
2ea2dee
to
fa2f3e4
Compare
@jpountz I updated the PR. |
LGTM |
…o the `_parent` field. Closes elastic#7394 Closes elastic#7402
fa2f3e4
to
b6cdb1d
Compare
_parent
field._parent
field.
_parent
field._parent
field.
_parent
field._parent
field.
…o the `_parent` field. Closes elastic#7394 Closes elastic#7402
PR for #7394