Make sure channel closing never happens on i/o thread #7726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to NettyTransport.doStop() all actions which disconnect from a node (and thus call awaitUnterruptibly) should not be executed on the I/O thread. This patch ensures that all disconnects happen in the generic threadpool. Also added a missing return statement in case the component was not yet started when catching an exception on the netty layer.
|
LGTM |
spinscale
added a commit
that referenced
this pull request
Sep 15, 2014
Similar to NettyTransport.doStop() all actions which disconnect from a node (and thus call awaitUnterruptibly) should not be executed on the I/O thread. This patch ensures that all disconnects happen in the generic threadpool, trying to avoid unnecessary `disconnectFromNode` calls. Also added a missing return statement in case the component was not yet started when catching an exception on the netty layer. Closes #7726
spinscale
added a commit
that referenced
this pull request
Sep 15, 2014
Similar to NettyTransport.doStop() all actions which disconnect from a node (and thus call awaitUnterruptibly) should not be executed on the I/O thread. This patch ensures that all disconnects happen in the generic threadpool, trying to avoid unnecessary `disconnectFromNode` calls. Also added a missing return statement in case the component was not yet started when catching an exception on the netty layer. Closes #7726
clintongormley
added
the
:Distributed/Network
clintongormley
changed the title
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
Similar to NettyTransport.doStop() all actions which disconnect from a node (and thus call awaitUnterruptibly) should not be executed on the I/O thread. This patch ensures that all disconnects happen in the generic threadpool, trying to avoid unnecessary `disconnectFromNode` calls. Also added a missing return statement in case the component was not yet started when catching an exception on the netty layer. Closes elastic#7726
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to NettyTransport.doStop() all actions which disconnect
from a node (and thus call awaitUnterruptibly) should not be executed
on the I/O thread.
This patch ensures that all disconnects happen in the generic threadpool.
Also added a missing return statement in case the component was not yet
started when catching an exception on the netty layer.