Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "noop" request breaker a non-dynamic setting #8179

Merged
merged 1 commit into from Oct 22, 2014

Conversation

dakrone
Copy link
Member

@dakrone dakrone commented Oct 21, 2014

The issue with making it dynamic is that in the event a cluster is
switched from a noop to a concrete implementation, there may be
in-flight requests, once these requests complete we adjust the breaker
with a negative number and trip an assertion.

@@ -450,20 +448,11 @@ protected boolean randomizeNumberOfShardsAndReplicas() {
return compatibilityVersion().onOrAfter(Version.V_1_1_0);
}

/** Rarely set the request breaker to a Noop breaker */
protected static void setRandomBreakerSettings(Random random, ImmutableSettings.Builder builder) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make this a random setting on the node in InternalTestCluster?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is if it is a noop breaker, we can't run any of the circuit breaker tests, should I add a change that tries to detect the type of breaker and skip the tests if it's a noop breaker?

@s1monw
Copy link
Contributor

s1monw commented Oct 21, 2014

left one comment other than that LGTM

The issue with making it dynamic is that in the event a cluster is
switched from a noop to a concrete implementation, there may be
in-flight requests, once these requests complete we adjust the breaker
with a negative number and trip an assertion.

This also rarely uses noop breakers in InternalTestCluster
@dakrone dakrone merged commit f7d227e into elastic:master Oct 22, 2014
@clintongormley clintongormley added >bug and removed review labels Nov 3, 2014
@clintongormley clintongormley changed the title Make "noop" request breaker a non-dynamic setting Internal: Make "noop" request breaker a non-dynamic setting Nov 3, 2014
@dakrone dakrone deleted the noop-non-dynamic branch November 11, 2014 12:42
@clintongormley clintongormley changed the title Internal: Make "noop" request breaker a non-dynamic setting Make "noop" request breaker a non-dynamic setting Jun 7, 2015
@clintongormley clintongormley added the :Core/Infra/Circuit Breakers Track estimates of memory consumption to prevent overload label Jun 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Core/Infra/Circuit Breakers Track estimates of memory consumption to prevent overload v1.4.0 v2.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants