Calculate Alder32 Checksums for legacy files in Store#checkIntegrity #8407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1monw
added
>enhancement
resiliency
v2.0.0-beta1
v1.5.0
v1.4.1
v1.3.6
>bug
review
and removed
>enhancement
labels
| public static boolean checkIntegrity(final StoreFileMetaData md, final Directory directory) { | ||
| try (IndexInput input = directory.openInput(md.name(), IOContext.READONCE)) { | ||
| if (md.writtenBy() != null && md.writtenBy().onOrAfter(Version.LUCENE_4_8_0)) { | ||
| if (input.length() != md.length()) { |
There was a problem hiding this comment.
Can this be moved up above the if, so its always checked?
|
@rmuir pushed an update |
|
+1 |
…tegrity Previously we didn't calculate this checksums even though we have a checksum to compare. Since we now also verify checksums for legacy files #checkIntegrity should also calculate the legacy checksums. Closes elastic#8407
s1monw
force-pushed
the
integrity_check_legacy
branch
from
06c687a
to
2eccbf5
Compare
s1monw
added a commit
to s1monw/elasticsearch
that referenced
this pull request
Nov 9, 2014
…tegrity Previously we didn't calculate this checksums even though we have a checksum to compare. Since we now also verify checksums for legacy files #checkIntegrity should also calculate the legacy checksums. Closes elastic#8407
s1monw
added a commit
to s1monw/elasticsearch
that referenced
this pull request
Nov 9, 2014
…tegrity Previously we didn't calculate this checksums even though we have a checksum to compare. Since we now also verify checksums for legacy files #checkIntegrity should also calculate the legacy checksums. Closes elastic#8407
s1monw
added a commit
that referenced
this pull request
Nov 9, 2014
…tegrity Previously we didn't calculate this checksums even though we have a checksum to compare. Since we now also verify checksums for legacy files #checkIntegrity should also calculate the legacy checksums. Closes #8407
clintongormley
changed the title
clintongormley
added
:Distributed/Store
clintongormley
changed the title
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
…tegrity Previously we didn't calculate this checksums even though we have a checksum to compare. Since we now also verify checksums for legacy files #checkIntegrity should also calculate the legacy checksums. Closes elastic#8407
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
…tegrity Previously we didn't calculate this checksums even though we have a checksum to compare. Since we now also verify checksums for legacy files #checkIntegrity should also calculate the legacy checksums. Closes elastic#8407
clintongormley
added
:Distributed/Engine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we didn't calculate this checksums even though we have a checksum
to compare. Since we now also verify checksums for legacy files #checkIntegrity
should also calculate the legacy checksums.