Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bloom filter overestimates ram usage by order of magnitude #8564

Closed
rmuir opened this issue Nov 20, 2014 · 0 comments · Fixed by #8584
Closed

bloom filter overestimates ram usage by order of magnitude #8564

rmuir opened this issue Nov 20, 2014 · 0 comments · Fixed by #8584
Labels
>bug PITA

Comments

@rmuir
Copy link
Contributor

rmuir commented Nov 20, 2014

I found this by dropping bloom filter code into lucene test suite. There are consistent failures:

java.lang.AssertionError: Actual RAM usage 136880, but got 915568, -568.8836937463471% error

I think we should just stop writing these?
@rmuir rmuir mentioned this issue Nov 20, 2014
Closed
s1monw added a commit to s1monw/elasticsearch that referenced this issue Nov 20, 2014
@s1monw
[BLOOM] Fix Bloom filter ram usage calculation
3e1b7c7 
BloomFilter actually returned the size of the bitset as the
size in bytes so off by factor 8 plus a constant :)

Closes elastic#8564
@s1monw s1monw mentioned this issue Nov 20, 2014
Merged
s1monw added a commit to s1monw/elasticsearch that referenced this issue Nov 20, 2014
@s1monw
[BLOOM] Fix Bloom filter ram usage calculation
ef03c8a 
BloomFilter actually returned the size of the bitset as the
size in bytes so off by factor 8 plus a constant :)

Closes elastic#8564
s1monw added a commit that referenced this issue Nov 20, 2014
@s1monw
[BLOOM] Fix Bloom filter ram usage calculation
fb8ae25 
BloomFilter actually returned the size of the bitset as the
size in bytes so off by factor 8 plus a constant :)

Closes #8564
s1monw added a commit that referenced this issue Nov 20, 2014
@s1monw
[BLOOM] Fix Bloom filter ram usage calculation
f7b04e2 
BloomFilter actually returned the size of the bitset as the
size in bytes so off by factor 8 plus a constant :)

Closes #8564
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
@s1monw
[BLOOM] Fix Bloom filter ram usage calculation
344196f 
BloomFilter actually returned the size of the bitset as the
size in bytes so off by factor 8 plus a constant :)

Closes elastic#8564
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
@s1monw
[BLOOM] Fix Bloom filter ram usage calculation
da1331e 
BloomFilter actually returned the size of the bitset as the
size in bytes so off by factor 8 plus a constant :)

Closes elastic#8564
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>bug PITA
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Bloom filter ram usage calculation s1monw/elasticsearch
1 participant
@rmuir