Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings: Fix cluster.routing.allocation.disk.include_relocations setting #8813

Merged
merged 1 commit into from Dec 8, 2014

Conversation

dakrone
Copy link
Member

@dakrone dakrone commented Dec 8, 2014

This setting was incorrectly backported and as a result, was dynamically
settable, but the new setting never actually took effect.

This is only going into the 1.4 branch, as it already exists in the 1.x and
master branches.

This setting was incorrectly backported and as a result, was dynamically
settable, but the new setting never actually took effect.
@bleskes
Copy link
Contributor

bleskes commented Dec 8, 2014

LGTM

@s1monw
Copy link
Contributor

s1monw commented Dec 8, 2014

any chance we can get a small unittest for this to all branches that makes sure it actually works?

@dakrone
Copy link
Member Author

dakrone commented Dec 8, 2014

@s1monw I will submit that as a separate PR, since this is only going to 1.4

@dakrone dakrone merged commit 6a36cec into elastic:1.4 Dec 8, 2014
@dakrone dakrone deleted the fix-dtd-backport branch December 12, 2014 16:22
@clintongormley clintongormley changed the title Fix cluster.routing.allocation.disk.include_relocations setting Settings: Fix cluster.routing.allocation.disk.include_relocations setting Dec 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants