Engine: back port fix to a potential dead lock when failing engine during COMMIT_TRANSLOG flush #9501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ring COMMIT_TRANSLOG flush This was fixed as part of elastic#9211
|
this looks great, I think all the asserts and the threadlocal in the InternalLock is now unused and can be removed too? |
|
@s1monw good catch. Removed. |
|
LGTM |
|
pushed. Thx. |
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
…ring COMMIT_TRANSLOG flush This was fixed as part of elastic#9211 Closes elastic#9501
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current failShard method calls the close() method, which acquired a writer lock. If the thread comes from the flush COMMIT_TRANSLOG flush path, it already has a reader lock. This is detected by an assertion that tripped in one of our test runs.
This was fixed as part of #9211