Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent negative intervals in date_histogram #9690

Closed
wants to merge 1 commit into from

Conversation

cbuescher
Copy link
Member

Negative settings for interval in date_histogram could lead to OOM errors in conjunction with min_doc_count=0. This fix raises exceptions in the histogram builder and the TimeZoneRounding classes so that the query fails before this can happen.

Closes #9634

@jpountz
Copy link
Contributor

jpountz commented Feb 13, 2015

LGTM

cbuescher pushed a commit that referenced this pull request Feb 13, 2015
Negative settings for interval in date_histogram could lead to OOM errors in conjunction
with min_doc_count=0. This fix raises exceptions in the histogram builder and the
 TimeZoneRounding classes so that the query fails before this can happen.

Closes #9690
cbuescher pushed a commit that referenced this pull request Feb 13, 2015
Negative settings for interval in date_histogram could lead to OOM errors in conjunction
with min_doc_count=0. This fix raises exceptions in the histogram builder and the
 TimeZoneRounding classes so that the query fails before this can happen.

Closes #9634
Closes #9690
@cbuescher cbuescher closed this in c597d8d Feb 13, 2015
@clintongormley clintongormley changed the title Aggregations: Prevent negative intervals in date_histogram Prevent negative intervals in date_histogram Jun 7, 2015
mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015
Negative settings for interval in date_histogram could lead to OOM errors in conjunction
with min_doc_count=0. This fix raises exceptions in the histogram builder and the
 TimeZoneRounding classes so that the query fails before this can happen.

Closes elastic#9690
@cbuescher cbuescher deleted the fix/9634 branch March 31, 2016 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants