Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query DSL: Terms Filter #1

Closed
kimchy opened this issue Feb 9, 2010 · 1 comment
Closed

Query DSL: Terms Filter #1

kimchy opened this issue Feb 9, 2010 · 1 comment

Comments

@kimchy
Copy link
Member

kimchy commented Feb 9, 2010

Support terms filter which allows to configure more than one term for a specific field. For example:

{
    filteredQuery : {
        query : {
            term : { "name.first" : "shay" }
        },
        filter : {
            terms : {
                "name.last" : ["banon", "kimchy"]
            }
        }
    }
}
@kimchy
Copy link
Member Author

kimchy commented Feb 9, 2010

Support terms filter, closed by bd2b0a6

pdegeus referenced this issue in pdegeus/elasticsearch Mar 20, 2013
nik9000 referenced this issue in nik9000/elasticsearch Nov 4, 2013
This implementation has a bunch of problems that'll need to be worked
before it is a valid candidate for merging.  I don't have time to rebase
it right now but would still love the feedback on problem.  The ones I
remember:

1.  It performs the filtering by blocking the suggesting thread.
2.  Because there is no "exists" query type it uses a limit.  I now know
that isn't ass efficient as just using a count but it might be worth
implementing an exists query type for it any way.
3.  It feels like there are a lot of plumbing changes required for this
feature.  My guess is that is because I'm going about it wrong.  This
correlates with #1 pretty well.
4.  I have to wrap the filter through the map nodes and parse it during
the reduce step.  That feels silly.

Closes elastic#3482
mrsolo added a commit that referenced this issue Jan 16, 2014
markharwood referenced this issue in kimchy/elasticsearch Mar 22, 2014
A frequency caching terms enum, that also allows to be configured with an optional filter. To be used by both significant terms and phrase suggester.
This change extracts the frequency caching into the same code, and allow in the future to add a filter to control/customize the background frequencies
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant