Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java API: XContentFactory creation of XContentBuilder to always be "safe" #1291

Closed
kimchy opened this issue Aug 31, 2011 · 0 comments
Closed

Comments

@kimchy
Copy link
Member

kimchy commented Aug 31, 2011

Currently, we do some thread local caching of buffers in order to reduce buffer copying when using the typical XContentFactory#jsonBuilder (for example). This can create dangerous bugs of overlapping buffers if the builder is not passed to the API right when its created. Remove this behavior, and optimize in other manners in order to reduce buffer copying.

Note, this means that the "safe" methods will be removed from the XContentFactory.

@kimchy kimchy closed this as completed in bc1dd10 Aug 31, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant