Highlighting broken when query is on `_all` field or with prefixes #148

clintongormley · 2010-04-21T20:22:52Z

Hiya

Load this data:

curl -XPUT 'http://127.0.0.2:9200/es_test_1/'  -d '
{}
'
curl -XPUT 'http://127.0.0.2:9200/es_test_2/'  -d '
{}
'
curl -XPUT 'http://127.0.0.2:9200/_all/type_1/_mapping'  -d '
{
   "_all" : {
      "store" : "yes",
      "term_vector" : "with_positions_offsets"
   },
   "properties" : {
      "num" : {
         "store" : "yes",
         "type" : "integer"
      },
      "date" : {
         "format" : "yyyy-MM-dd HH:mm:ss",
         "type" : "date"
      },
      "text" : {
         "store" : "yes",
         "type" : "string"
      }
   }
}
'
curl -XPUT 'http://127.0.0.2:9200/_all/type_2/_mapping'  -d '
{
   "_all" : {
      "store" : "yes",
      "term_vector" : "with_positions_offsets"
   },
   "properties" : {
      "num" : {
         "store" : "yes",
         "type" : "integer"
      },
      "date" : {
         "format" : "yyyy-MM-dd HH:mm:ss",
         "type" : "date"
      },
      "text" : {
         "store" : "yes",
         "type" : "string"
      }
   }
}
'
curl -XPOST 'http://127.0.0.2:9200/_refresh' 
curl -XGET 'http://127.0.0.2:9200/_cluster/health?timeout=2s&wait_for_status=green' 
curl -XPUT 'http://127.0.0.2:9200/es_test_1/type_1/1/_create'  -d '
{
   "num" : "2",
   "date" : "2010-04-2 00:00:00",
   "text" : "foo"
}
'
curl -XPUT 'http://127.0.0.2:9200/es_test_1/type_2/2/_create'  -d '
{
   "num" : "3",
   "date" : "2010-04-3 00:00:00",
   "text" : "foo"
}
'
curl -XPUT 'http://127.0.0.2:9200/es_test_2/type_1/3/_create'  -d '
{
   "num" : "4",
   "date" : "2010-04-4 00:00:00",
   "text" : "foo"
}
'
curl -XPUT 'http://127.0.0.2:9200/es_test_2/type_2/4/_create'  -d '
{
   "num" : "5",
   "date" : "2010-04-5 00:00:00",
   "text" : "foo"
}
'
curl -XPUT 'http://127.0.0.2:9200/es_test_1/type_1/5/_create'  -d '
{
   "num" : "6",
   "date" : "2010-04-6 00:00:00",
   "text" : "foo bar"
}
'
curl -XPUT 'http://127.0.0.2:9200/es_test_1/type_2/6/_create'  -d '
{
   "num" : "7",
   "date" : "2010-04-7 00:00:00",
   "text" : "foo bar"
}
'
curl -XPUT 'http://127.0.0.2:9200/es_test_2/type_1/7/_create'  -d '
{
   "num" : "8",
   "date" : "2010-04-8 00:00:00",
   "text" : "foo bar"
}
'
curl -XPUT 'http://127.0.0.2:9200/es_test_2/type_2/8/_create'  -d '
{
   "num" : "9",
   "date" : "2010-04-9 00:00:00",
   "text" : "foo bar"
}
'
curl -XPUT 'http://127.0.0.2:9200/es_test_1/type_1/9/_create'  -d '
{
   "num" : "10",
   "date" : "2010-04-10 00:00:00",
   "text" : "foo bar baz"
}
'
curl -XPUT 'http://127.0.0.2:9200/es_test_1/type_2/10/_create'  -d '
{
   "num" : "11",
   "date" : "2010-04-11 00:00:00",
   "text" : "foo bar baz"
}
'
curl -XPUT 'http://127.0.0.2:9200/es_test_2/type_1/11/_create'  -d '
{
   "num" : "12",
   "date" : "2010-04-12 00:00:00",
   "text" : "foo bar baz"
}
'
curl -XPUT 'http://127.0.0.2:9200/es_test_2/type_2/12/_create'  -d '
{
   "num" : "13",
   "date" : "2010-04-13 00:00:00",
   "text" : "foo bar baz"
}
'
curl -XPUT 'http://127.0.0.2:9200/es_test_1/type_1/13/_create'  -d '
{
   "num" : "14",
   "date" : "2010-04-14 00:00:00",
   "text" : "bar baz"
}
'
curl -XPUT 'http://127.0.0.2:9200/es_test_1/type_2/14/_create'  -d '
{
   "num" : "15",
   "date" : "2010-04-15 00:00:00",
   "text" : "bar baz"
}
'
curl -XPUT 'http://127.0.0.2:9200/es_test_2/type_1/15/_create'  -d '
{
   "num" : "16",
   "date" : "2010-04-16 00:00:00",
   "text" : "bar baz"
}
'
curl -XPUT 'http://127.0.0.2:9200/es_test_2/type_2/16/_create'  -d '
{
   "num" : "17",
   "date" : "2010-04-17 00:00:00",
   "text" : "bar baz"
}
'
curl -XPUT 'http://127.0.0.2:9200/es_test_1/type_1/17/_create'  -d '
{
   "num" : "18",
   "date" : "2010-04-18 00:00:00",
   "text" : "baz"
}
'
curl -XPUT 'http://127.0.0.2:9200/es_test_1/type_2/18/_create'  -d '
{
   "num" : "19",
   "date" : "2010-04-19 00:00:00",
   "text" : "baz"
}
'
curl -XPUT 'http://127.0.0.2:9200/es_test_2/type_1/19/_create'  -d '
{
   "num" : "20",
   "date" : "2010-04-20 00:00:00",
   "text" : "baz"
}
'
curl -XPUT 'http://127.0.0.2:9200/es_test_2/type_2/20/_create'  -d '
{
   "num" : "21",
   "date" : "2010-04-21 00:00:00",
   "text" : "baz"
}
'
curl -XPUT 'http://127.0.0.2:9200/es_test_1/type_1/21/_create'  -d '
{
   "num" : "22",
   "date" : "2010-04-22 00:00:00",
   "text" : "bar"
}
'
curl -XPUT 'http://127.0.0.2:9200/es_test_1/type_2/22/_create'  -d '
{
   "num" : "23",
   "date" : "2010-04-23 00:00:00",
   "text" : "bar"
}
'
curl -XPUT 'http://127.0.0.2:9200/es_test_2/type_1/23/_create'  -d '
{
   "num" : "24",
   "date" : "2010-04-24 00:00:00",
   "text" : "bar"
}
'
curl -XPUT 'http://127.0.0.2:9200/es_test_2/type_2/24/_create'  -d '
{
   "num" : "25",
   "date" : "2010-04-25 00:00:00",
   "text" : "bar"
}
'
curl -XPUT 'http://127.0.0.2:9200/es_test_1/type_1/25/_create'  -d '
{
   "num" : "26",
   "date" : "2010-04-26 00:00:00",
   "text" : "foo baz"
}
'
curl -XPUT 'http://127.0.0.2:9200/es_test_1/type_2/26/_create'  -d '
{
   "num" : "27",
   "date" : "2010-04-27 00:00:00",
   "text" : "foo baz"
}
'
curl -XPUT 'http://127.0.0.2:9200/es_test_2/type_1/27/_create'  -d '
{
   "num" : "28",
   "date" : "2010-04-28 00:00:00",
   "text" : "foo baz"
}
'
curl -XPUT 'http://127.0.0.2:9200/es_test_2/type_2/28/_create'  -d '
{
   "num" : "29",
   "date" : "2010-04-29 00:00:00",
   "text" : "foo baz"
}
'

Then try these queries:

TERM QUERY: WORKS

curl -XGET 'http://127.0.0.2:9200/_all/_search'  -d '
{
   "query" : {
      "term" : {
         "text" : "foo"
      }
   },
   "highlight" : {
      "fields" : {
         "_all" : {}
      }
   },
   "size" : 2
}
'
# {
#    "hits" : {
#       "hits" : [
#          {
#             "_source" : {
#                "num" : "3",
#                "text" : "foo",
#                "date" : "2010-04-3 00:00:00"
#             },
#             "_index" : "es_test_1",
#             "_id" : "2",
#             "_type" : "type_2",
#             "highlight" : {
#                "_all" : [
#                   "00:00 <em>foo</em> "
#                ]
#             }
#          },
#          {
#             "_source" : {
#                "num" : "5",
#                "text" : "foo",
#                "date" : "2010-04-5 00:00:00"
#             },
#             "_index" : "es_test_2",
#             "_id" : "4",
#             "_type" : "type_2",
#             "highlight" : {
#                "_all" : [
#                   "00:00 <em>foo</em> "
#                ]
#             }
#          }
#       ],
#       "total" : 16
#    },
#    "_shards" : {
#       "failed" : 0,
#       "successful" : 10,
#       "total" : 10
#    }
# }

PREFIX QUERY: BROKEN

curl -XGET 'http://127.0.0.2:9200/_all/_search'  -d '
{
   "query" : {
      "prefix" : {
         "text" : "foo"
      }
   },
   "highlight" : {
      "fields" : {
         "_all" : {}
      }
   },
   "size" : 2
}
'
# {
#    "hits" : {
#       "hits" : [
#          {
#             "_source" : {
#                "num" : "5",
#                "text" : "foo",
#                "date" : "2010-04-5 00:00:00"
#             },
#             "_index" : "es_test_2",
#             "_id" : "4",
#             "_type" : "type_2",
#             "highlight" : {
#                "_all" : []
#             }
#          },
#          {
#             "_source" : {
#                "num" : "4",
#                "text" : "foo",
#                "date" : "2010-04-4 00:00:00"
#             },
#             "_index" : "es_test_2",
#             "_id" : "3",
#             "_type" : "type_1",
#             "highlight" : {
#                "_all" : []
#             }
#          }
#       ],
#       "total" : 16
#    },
#    "_shards" : {
#       "failed" : 0,
#       "successful" : 10,
#       "total" : 10
#    }
# }

QUERY STRING ON FIELD: WORKS

curl -XGET 'http://127.0.0.2:9200/_all/_search'  -d '
{
   "query" : {
      "query_string" : {
         "query" : "text:foo"
      }
   },
   "highlight" : {
      "fields" : {
         "_all" : {}
      }
   },
   "size" : 2
}
'
# {
#    "hits" : {
#       "hits" : [
#          {
#             "_source" : {
#                "num" : "3",
#                "text" : "foo",
#                "date" : "2010-04-3 00:00:00"
#             },
#             "_index" : "es_test_1",
#             "_id" : "2",
#             "_type" : "type_2",
#             "highlight" : {
#                "_all" : [
#                   "00:00 <em>foo</em> "
#                ]
#             }
#          },
#          {
#             "_source" : {
#                "num" : "5",
#                "text" : "foo",
#                "date" : "2010-04-5 00:00:00"
#             },
#             "_index" : "es_test_2",
#             "_id" : "4",
#             "_type" : "type_2",
#             "highlight" : {
#                "_all" : [
#                   "00:00 <em>foo</em> "
#                ]
#             }
#          }
#       ],
#       "total" : 16
#    },
#    "_shards" : {
#       "failed" : 0,
#       "successful" : 10,
#       "total" : 10
#    }
# }

QUERY STRING ON ALL: BROKEN
curl -XGET 'http://127.0.0.2:9200/_all/_search' -d '
{
"query" : {
"query_string" : {
"query" : "foo"
}
},
"highlight" : {
"fields" : {
"_all" : {}
}
},
"size" : 2
}
'
# {
# "hits" : {
# "hits" : [
# {
# "_source" : {
# "num" : "3",
# "text" : "foo",
# "date" : "2010-04-3 00:00:00"
# },
# "_index" : "es_test_1",
# "_id" : "2",
# "_type" : "type_2",
# "highlight" : {
# "_all" : []
# }
# },
# {
# "_source" : {
# "num" : "6",
# "text" : "foo bar",
# "date" : "2010-04-6 00:00:00"
# },
# "_index" : "es_test_1",
# "_id" : "5",
# "_type" : "type_1",
# "highlight" : {
# "_all" : []
# }
# }
# ],
# "total" : 16
# },
# "_shards" : {
# "failed" : 0,
# "successful" : 10,
# "total" : 10
# }
# }

The text was updated successfully, but these errors were encountered:

kimchy · 2010-04-25T11:28:33Z

hey, found the reason for this, working on a fix. Is there a reason there are two issues for this?

kimchy · 2010-04-25T17:30:11Z

Highlighting broken when query is on _all field or with prefixes. Add also a flag to highlight to control if filters should be highlighted or not (called highlight_filters) which defaults to true. Closed by bf6cead.

Closes #148

We need to define `<elasticsearch.version>` in `pom.xml` as we now inherit from elasticsearch project parent pom. But `elasticsearch.version` is set by default to `project.version` which is here `3.0.0-SNAPSHOT` for the mapper project. Related to elastic#148

Fix compiling issues. Also fix test issues. Need now to move old integration tests to RESTIT Closes elastic#148.

in case the task id information is not present, log existing props for better debugging... relates elastic#148

relates to elastic#148

relates elastic#148

…lastic#148) add stack onto recorder metric name * add stack onto recorder metric name Approved-by: Gideon Avida

bluelu mentioned this issue Dec 11, 2014

Node is not responsive after the end of a big merge for close to 10 minutes #8905

Closed

tlrx added a commit that referenced this issue Jun 5, 2015

Update AWS SDK to 1.9.8

849e697

Closes #148

makeyang mentioned this issue Sep 7, 2015

es 0.90.2 plus jdk6.0_25-b06 crashed on production #13368

Closed

rmuir pushed a commit to rmuir/elasticsearch that referenced this issue Nov 8, 2015

[build] Update to elasticsearch 2.0.0

b0567d7

Fix compiling issues. Also fix test issues. Need now to move old integration tests to RESTIT Closes elastic#148.

r32rtb mentioned this issue Jun 8, 2018

After Upgrade to 6.2.4 Circuitbreaker Exception Data too large #31197

Closed

williamrandolph pushed a commit to williamrandolph/elasticsearch that referenced this issue Jun 4, 2020

fallback from task attempt to task id

cf49ea2

in case the task id information is not present, log existing props for better debugging... relates elastic#148

williamrandolph pushed a commit to williamrandolph/elasticsearch that referenced this issue Jun 4, 2020

allow fallback in heartbeat when the task id is lacking

0de2792

relates to elastic#148

williamrandolph pushed a commit to williamrandolph/elasticsearch that referenced this issue Jun 4, 2020

fix NPE in ReportingUtils

a1ce571

relates elastic#148

mindw pushed a commit to mindw/elasticsearch that referenced this issue Sep 5, 2022

Merged in dev/ttang2/add_stack_to_metric_name_21.06.14 (pull request e…

7a479e8

…lastic#148) add stack onto recorder metric name * add stack onto recorder metric name Approved-by: Gideon Avida

This issue was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Highlighting broken when query is on `_all` field or with prefixes #148

Highlighting broken when query is on `_all` field or with prefixes #148

clintongormley commented Apr 21, 2010

kimchy commented Apr 25, 2010

kimchy commented Apr 25, 2010

Highlighting broken when query is on _all field or with prefixes #148

Highlighting broken when query is on _all field or with prefixes #148

Comments

clintongormley commented Apr 21, 2010

kimchy commented Apr 25, 2010

kimchy commented Apr 25, 2010

Highlighting broken when query is on `_all` field or with prefixes #148

Highlighting broken when query is on `_all` field or with prefixes #148