Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move project build to maven #1523

Closed
kimchy opened this issue Dec 6, 2011 · 7 comments
Closed

Move project build to maven #1523

kimchy opened this issue Dec 6, 2011 · 7 comments

Comments

@kimchy
Copy link
Member

kimchy commented Dec 6, 2011

Move to maven for the build system. Since we moved all the plugins, we can use a single module (maven crap with multi module), which makes things simpler.

  • Creating a distribution using mvn assembly:assembly -DskipTests, it will be under target/releases.
@kimchy
Copy link
Member Author

kimchy commented Dec 6, 2011

Implemented, leftover is migrate the deb packaging from 0.18 branch to master using maven.

@kimchy kimchy closed this as completed Dec 6, 2011
@clintongormley
Copy link

Hiya

I tried building with maven - a couple of things:

  1. my mvn command turned out to be mvn3
  2. maven complained of the following:
[WARNING]
[WARNING] Some problems were encountered while building the effective model for org.elasticsearch:elasticsearch:jar:0.19.0-SNAPSHOT
[WARNING] 'dependencies.dependency.systemPath' for sigar:sigar:jar should not point at files within the project directory, ${basedir}/lib/sigar/sigar-1.6.4.jar will be unresolvable by dependent projects @ line 213, column 25
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
[WARNING]

but it built successfully

@kimchy
Copy link
Member Author

kimchy commented Dec 7, 2011

Cool, btw, that warning is "ok".

@karussell
Copy link
Contributor

Yeah, build is here ok too. Really nice :) BTW: what made you switching?

Some tests are failing (not sure if related to maven).

testSnapshotOperations * 2
assertThat(clusterState.state().metaData().index("test").mapping("type1"), notNullValue());

testRequiredRoutingMappingWithAlias
assertThat(client.prepareGet("test", "type1", "1").setRouting("0").execute().actionGet().exists(), equalTo(false));

testScriptFieldUsingSource
assertThat("Failures " + Arrays.toString(response.shardFailures()), response.shardFailures().length, equalTo(0));

testFiltersWithCustomeCacheKey
assertThat("Failures " + Arrays.toString(searchResponse.shardFailures()), searchResponse.shardFailures().length, equalTo(0));

@kimchy
Copy link
Member Author

kimchy commented Dec 8, 2011

@karussell switched because gradle made some changes in latest version that make it harder to get started without IDE support. Also, since I moved all the plugins to their own repos, then we can have a single module, and I never had major problems with maven on single module projects, its the multi module ones that caused me pain.

@karussell
Copy link
Contributor

Ah, ok.

I'm now done with the migration of the deb pkg and ElasticSearch even starts ;)

Pull request is coming ...

@oravecz
Copy link

oravecz commented May 14, 2012

So, are the plugins still hosted on Maven somewhere? Can't find them in their pre-0.19 location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants