Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

match_all filter with empty array (instead of obj) fires exception when used with facets #2493

Closed
gibrown opened this issue Dec 18, 2012 · 2 comments
Closed

match_all filter with empty array (instead of obj) fires exception when used with facets #2493

gibrown opened this issue Dec 18, 2012 · 2 comments
Labels
>enhancement v0.20.2 v0.90.0.Beta1

Comments

@gibrown
Copy link
Contributor

gibrown commented Dec 18, 2012

Granted an empty object is the correct syntax, but unfortunately in PHP this can get a little confusing since an empty assoc array json_encode()'s to an object, but of course encodes to an array when empty.

Very confusing for a little while.

Interestingly, if the facets are not included then it works either way.

Example: https://gist.github.com/4323746

running ES 0.19.9 (yeah still...)
@kimchy
Copy link
Member

kimchy commented Dec 26, 2012

We can easily fix it, will push a fix for master and 0.20.

@kimchy kimchy closed this as completed in 8a17222 Dec 26, 2012
kimchy added a commit that referenced this issue Dec 26, 2012
@kimchy
match_all filter with empty array (instead of obj) fires exception wh…
1ace5ca 
…en used with facets

fixes #2493
@gibrown
Copy link
Contributor Author

gibrown commented Dec 27, 2012

Awesome, thanks!

mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
@kimchy
match_all filter with empty array (instead of obj) fires exception wh…
dc2cd0d 
…en used with facets

fixes elastic#2493
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>enhancement v0.20.2 v0.90.0.Beta1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kimchy @gibrown