Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore_indices doesn't fail if all the indices requested are not present #2837

Closed
mahdeto opened this issue Apr 1, 2013 · 3 comments
Closed

ignore_indices doesn't fail if all the indices requested are not present #2837

mahdeto opened this issue Apr 1, 2013 · 3 comments
Labels
>breaking >bug v0.90.0.RC2

Comments

@mahdeto
Copy link
Contributor

mahdeto commented Apr 1, 2013

ignore_indices=missing doesn't fail if all the indices requested are not present, it defaults to searching everything which is far from desirable, specially when doing a heavy facet (e.g. termstats) in a daily index case (e.g. logs_2013-04-01) and there is no data indexed for the day

To reproduce start a node and index any document to index "A" then curl this:

curl 'http://localhost:9200/B,C/_search?ignore_indices=missing&pretty'

Tried on 0.20.6 this returns the document just indexed to index "A".

If that is the expected behavior for the 'missing' value then I suggest adding another value to ignore_indices, for example "ignore_indices=missing_some" that will fail if none of the queried indices are there
mahdeto added a commit to mahdeto/elasticsearch that referenced this issue Apr 2, 2013
@mahdeto
setting ignore_indices=missing will fail your query if all the indice…
cbcf1df 
…s are missing as opposed to making your query run against everything.. fixes elastic#2837
@mahdeto mahdeto mentioned this issue Apr 2, 2013
Closed
@martijnvg
Copy link
Member

This isn't expected behaviour. I think the best thing if none of the specified indices exists, is to return an error.

@martijnvg
Copy link
Member

@mahdeto Thanks for reporting this issue! The fix (based on your fix) will be included in the next release.

@mahdeto
Copy link
Contributor Author

mahdeto commented Apr 2, 2013

Sweet :) glad I could help :) this was my first contrib to ES and hopefully
won't be the last.

On Tue, Apr 2, 2013 at 7:08 PM, Martijn van Groningen <
notifications@github.com> wrote:

@mahdeto https://github.com/mahdeto Thanks for reporting this issue!
The fix (based on your fix) will be included in the next release.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/2837#issuecomment-15788731
.

mahdeto added a commit to mahdeto/elasticsearch that referenced this issue Apr 4, 2013
@mahdeto
setting ignore_indices=missing will fail your query if all the indice…
6156db2 
…s are missing as opposed to making your query run against everything.. fixes elastic#2837
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>breaking >bug v0.90.0.RC2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for #2837 by checking if all the indices were missing and failing that. mahdeto/elasticsearch
2 participants
@martijnvg @mahdeto